Hi Tom,

On Thu, 20 Aug 2026 at 09:10, Tom Rini <[email protected]> wrote:
>
> On Thu, Aug 20, 2026 at 06:31:18AM -0600, Simon Glass wrote:
> > Hi Valentin,
> >
> > On 2026-08-18T17:53:00, Valentin Liu <[email protected]> wrote:
> > > boot: android: Add Android 13+ bootflow support to bootmeth.
> >
> > Please drop the trailing period and keep the subject under 60 characters.
> >
> > >
> > > The devices launching Android 13+ were using a new partition
> > > named init_boot to store generic ramdisk.
> >
> > >
> > > In the new bootflow, kernel still be stored in boot image,
> > > however, the First Stage files in ramdisk were moved to
> > > init_boot image. We should load it to memory and verify it
> > > so that the kernel can execute init program to continue booting.
> > >
> > > Currently, we have supported loading the init_boot image by
> > > abootimg command, but we still need bring this ability to
> > > bootmeth, so that booting Android 13+ will be more easily.
> >
> > Please use present/imperative tense throughout: 'were using' -> 'use',
> > 'kernel still be stored' -> 'the kernel is still stored', 'were moved'
> > -> 'are moved', 'we still need bring' -> 'we still need to bring',
> > 'more easily' -> 'easier'.
>
> We do not have any sort of grammar rules and requirements like that in
> the project, please stop giving people feedback like this.

As far as I am aware, as a project, we have followed these guidelines
for a long time:

https://www.kernel.org/doc/html/v7.0/process/submitting-patches.html#describe-your-changes

Regards,
Simon

Reply via email to