On 27/08/2026 at 13:11:51 +02, Michal Simek <[email protected]> wrote:
> On 7/2/26 15:08, Bastien Curutchet wrote: >> This driver is deeply broken in many ways. Miquèl has cleaned it up by: >> - flagging the most hideous parts (where Micron on-die ECC support is >> hardcoded) >> - enabling DT support, eg. for reading the ECC configuration >> - fixing software ECC support >> - aligning the software ECC OOB layout to the rest of the world and >> allow a working interoperability in Linux. >> I then added a patch to fix writes when soft ECC is on. >> Signed-off-by: Miquel Raynal (DAVE.eu) <[email protected]> >> Signed-off-by: Bastien Curutchet (DAVE.eu) <[email protected]> >> --- >> Changes in v3: >> - Add patch 6 to fix write issues in soft ECC. >> - Link to v2: >> https://lore.kernel.org/r/[email protected] >> Changes in v2: >> - Fix the sponsor: s/DAVE/DAVE.eu/, no other change. >> - Link to v1: >> https://lore.kernel.org/r/[email protected] >> --- >> Bastien Curutchet (DAVE.eu) (1): >> mtd: rawnand: nand_base: Don't overwrite read/write_page_raw() for >> soft ECC >> Miquel Raynal (DAVE.eu) (5): >> mtd: rawnand: zynq: Align the layout structures with the driver >> namespace >> mtd: rawnand: zynq: Add comments about very bad practices >> mtd: rawnand: zynq: Make sure an of node is attached >> mtd: rawnand: zynq: Do not fail the probe for no reason >> mtd: rawnand: zynq: Fix Software ECC engine support >> drivers/mtd/nand/raw/nand_base.c | 6 +- >> drivers/mtd/nand/raw/zynq_nand.c | 115 >> ++++++++++----------------------------- >> 2 files changed, 32 insertions(+), 89 deletions(-) >> --- >> base-commit: 4433253ecf2041f9362a763bb6cb79960921ac7e >> change-id: 20260522-dave-upstream-nand-fixes-60a5336517a2 >> Best regards, > > Any progress on this series? I also think patch 1 & 2 are safe to apply. > I can't see any issue with applying 1-2 patches. > Patch 4 it is not clear what exactly is failing for you. IIRC there are > certain pins dedicated to NAND and all of them should be assigned to > it. If it is not then you have different problem. We do not have pin issues, software ECC has never worked, that is what we tried to implement. Yet, we will double check pin assignment. At this stage everything works on our side on a slightly older than mainline version with board specific patches. We need to forward port these patches to find what is broken on Kumar's side, but that task has been stalled. Thanks, Miquèl
