On Tue, Sep 01, 2026 at 07:47:36AM -0600, Simon Glass wrote: > Hi Naveen, > > On 2026-09-01T10:23:25, Naveen Kumar Chaudhary <[email protected]> wrote: > > bootstage: fix unchecked malloc and undersized buffer in > > bootstage_mark_code() > > > > bootstage_mark_code() allocated the label buffer without checking the > > result and then dereferenced it, risking a NULL pointer crash on > > allocation failure. The length calculation also failed to account for > > the "," and ": " separators emitted by the snprintf() calls, so the > > assembled string could be silently truncated. Additionally, when file > > and func are NULL and linenum is -1, the buffer was passed on > > uninitialized. > > Please rewrite in present tense per U-Boot / Linux convention, e.g. > 'allocates the label buffer without checking the result', 'fails to > account for', 'is passed on uninitialised'. This patch aims to change > the current code.
Hi Simon, As I said the other day, please stop telling people to rewrite their commit messages when it's already clear and understandable. This simply leads to confusion and frustration among our contributors. -- Tom
signature.asc
Description: PGP signature
