On 03/09/2026 07:20, Balaji Selvanathan wrote:
> serial# is flagged write-once (ENV_FLAGS_VARACCESS_PREVENT_OVERWR), so
> setting it again after it has been loaded from a saved environment
> gives following unnecessary error logs, which can be avoided.
>
> ## Error: Can't overwrite "serial#"
> ## Error inserting "serial#" variable, errno=1
>
> Return early from qcom_set_serialno() if serial# is already set.
>
> Signed-off-by: Balaji Selvanathan <[email protected]>
Reviewed-by: Casey Connolly <[email protected]>
> ---
> This patch depends on
> https://git.u-boot-project.org/u-boot/u-boot/-/commit/7c957182640da775ae6dd7a9456b6a6a8532c4ed
> mmerged in u-boot/next.
> ---
> arch/arm/mach-snapdragon/board.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/mach-snapdragon/board.c
> b/arch/arm/mach-snapdragon/board.c
> index 80bf510d31f..e8653460707 100644
> --- a/arch/arm/mach-snapdragon/board.c
> +++ b/arch/arm/mach-snapdragon/board.c
> @@ -208,6 +208,9 @@ void qcom_set_serialno(void)
> const char *cmdline;
> char serial[32];
>
> + if (env_get("serial#"))
> + return;
> +
> if (!qcom_socinfo_init())
> return;
>
>
> ---
> base-commit: b55d2b12d3a88d003a9911adc8d96e4921f67ad1
> change-id: 20260902-snapdragon-serialno-write-once-7c7c3cc3863d
>
> Best regards,
--
// Casey (she/her)
