Check the return value of dev_remap_addr_name() for NULL instead of
IS_ERR(). This function only ever returns NULL on failure.

Fixes: 9d8f78a2a79f ("net: add hifemac Ethernet driver for HiSilicon platform")
Signed-off-by: David Lechner <[email protected]>
---
 drivers/net/hifemac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/hifemac.c b/drivers/net/hifemac.c
index 7dda8cb8815..ed983e0b263 100644
--- a/drivers/net/hifemac.c
+++ b/drivers/net/hifemac.c
@@ -435,7 +435,7 @@ static int hisi_femac_of_to_plat(struct udevice *dev)
        }
 
        priv->glb_base = dev_remap_addr_name(dev, "glb");
-       if (IS_ERR(priv->glb_base)) {
+       if (!priv->glb_base) {
                dev_err(dev, "Failed to remap global address space\n");
                return log_msg_ret("net", -EINVAL);
        }

-- 
2.43.0

Reply via email to