On Wed, Sep 09, 2026 at 04:20, Marek Vasut <[email protected]> wrote:
> Hello Thinh,
>
> On 9/9/26 3:58 AM, Thinh Nguyen wrote:
>> On Fri, Sep 04, 2026, Marek Vasut wrote:
>>> On 9/4/26 4:29 AM, Thinh Nguyen wrote:
>>>
>>> Hello Thinh,
>>>
>>>> @@ -2709,6 +2712,27 @@ static int fsg_bind(struct usb_configuration *c,
>>>> struct usb_function *f)
>>>> return -ENOMEM;
>>>> }
>>>> }
>>>> +
>>>> + if (gadget_is_superspeed(gadget)) {
>>>
>>> Nitpick -- you could invert the conditional here and reduce indent:
>>>
>>> if (!gadget_is_superspeed(gadget))
>>> return 0;
>>>
>>> ...
>>>
>>
>> But wouldn't that deviate further from the original Linux
>> change? See:
>>
>> 4bb99b7c82ba ("usb: gadget: storage: add superspeed support")
>
> I think we are past that point and the U-Boot code did already diverge
> quite a bit, but if this is pulled from some specific Linux commit and
> you want to retain the code similarity, then please at least include the
> aforementioned Linux commit reference in the commit message.
I've been (over-)zealous with keeping the code similar to the Linux
commit.
Sorry if that was a problem.
To me it looks good this way.
>
> 'From Linux 4bb99b7c82ba ("usb: gadget: storage: add superspeed
> support").' or something along these lines.
I can add that to the commit message when applying.
>
> Thank you !
>
> --
> Best regards,
> Marek Vasut
