On 9/23/26 9:25 AM, Carlo Caione wrote: > On Tue, Sep 22, 2026 at 11:27:35 +0100, David Lechner wrote: >> On 9/14/26 8:35 AM, Carlo Caione wrote: >>> Some provisioning flows need U-Boot's command support in addition to >>> fastboot. Provide a U-Boot-based download agent for Genio 510 and 700 so >>> these flows can run without relying on firmware already stored on the >>> board. >>
... >>> #if defined(CONFIG_SPL_SPI) >>> return BOOT_DEVICE_SPI; >>> #elif defined(CONFIG_SPL_MMC) >> Should we have a precursor patch to clean up the existing entries to also >> use CONFIG_IS_ENABLED() to keep this consistent? > > I'll clean it up in this set, no need to have a precursor patch. > >> (And I assume in the config from the first patch, this would fall though to >> BOOT_DEVICE_NONE since there is no u-boot proper in that case?) > > mmh no, spl_boot_device() returns BOOT_DEVICE_MMC1, not > BOOT_DEVICE_NONE. The point is that there is no U-Boot proper inside the > SPL DA, but SPL can load it from eMMC. I might not have written this down in the review. When I was looking over this, I was wondering if running the download agent should always end with a reset/reboot or if it is supposed to be able to jump to u-boot proper or linux without rebooting first. > > Thank you for the review, > > -- > Carlo Caione
