Hi Aristo,

On 9/23/26 5:45 PM, Aristo Chen wrote:
include/image.h defines constants for the FIT property names, but
mkimage still spells out two of them as string literals.

When the signing algorithm is given with -o, fit_image_write_sig()
records it in the "algo" property of the signature node using a
literal, while fit_image_hash_get_algo(), which mkimage and the
verification code use to read that property, uses FIT_ALGO_PROP. Use
the constant for the write as well.

fdt_property_file() takes the property name as an argument but ignores
it and always writes "data". Every caller passes FIT_DATA_PROP, so use
the argument.

No functional change.


Considering there's a small trick for one the changes, maybe separate commits would have been better, but in any case:

Reviewed-by: Quentin Schulz <[email protected]>

Thanks!
Quentin

Reply via email to