On 9/24/26 11:03 AM, Arnaud Ferraris wrote:
> Add pinctrl driver for mt8196. The driver is based on the kernel driver.
>
> Signed-off-by: Arnaud Ferraris <[email protected]>
> ---
> drivers/pinctrl/mediatek/Makefile | 1 +
> drivers/pinctrl/mediatek/pinctrl-mt8196.c | 1905
> +++++++++++++++++++++++++++++
> 2 files changed, 1906 insertions(+)
>
> diff --git a/drivers/pinctrl/mediatek/Makefile
> b/drivers/pinctrl/mediatek/Makefile
> index 0e6eedba9c4..6ea55030bba 100644
> --- a/drivers/pinctrl/mediatek/Makefile
> +++ b/drivers/pinctrl/mediatek/Makefile
> @@ -13,6 +13,7 @@ obj-$(CONFIG_TARGET_MT7988) += pinctrl-mt7988.o
> obj-$(CONFIG_TARGET_MT8188) += pinctrl-mt8188.o
> obj-$(CONFIG_TARGET_MT8189) += pinctrl-mt8189.o
> obj-$(CONFIG_TARGET_MT8195) += pinctrl-mt8195.o
> +obj-$(CONFIG_TARGET_MT8196) += pinctrl-mt8196.o
> obj-$(CONFIG_TARGET_MT8365) += pinctrl-mt8365.o
> obj-$(CONFIG_TARGET_MT8366) += pinctrl-mt8366.o
> obj-$(CONFIG_TARGET_MT8512) += pinctrl-mt8512.o
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8196.c
> b/drivers/pinctrl/mediatek/pinctrl-mt8196.c
> new file mode 100644
> index 00000000000..750f4eda029
> --- /dev/null
> +++ b/drivers/pinctrl/mediatek/pinctrl-mt8196.c
> @@ -0,0 +1,1905 @@
> +// SPDX-License-Identifier: GPL-2.0
GPL-2.0 is ambiguous and deprecated. Prefer GPL-2.0-only or GPL-2.0-or-later.
> +static const struct mtk_pin_desc mt8196_pins[] = {
> + MT8196_TYPE0_PIN(0, "DMIC1_CLK"),
> + MT8196_TYPE0_PIN(1, "DMIC1_DAT"),
> + MT8196_TYPE0_PIN(2, "PWM_VLP"),
> + MT8196_TYPE0_PIN(3, "MD_INT0"),
> + MT8196_TYPE0_PIN(4, "DISP_PWM1"),
> + MT8196_TYPE0_PIN(5, "LCM1_RST"),
> + MT8196_TYPE0_PIN(6, "DSI1_TE"),
> + MT8196_TYPE0_PIN(7, "GPIO_7"),
> + MT8196_TYPE0_PIN(8, "GPIO_8"),
> + MT8196_TYPE0_PIN(9, "GPIO_9"),
> + MT8196_TYPE0_PIN(10, "GPIO_10"),
> + MT8196_TYPE0_PIN(11, "GPIO_11"),
> + MT8196_TYPE0_PIN(12, "GPIO_12"),
> + MT8196_TYPE0_PIN(13, "EDP_TX_HPD"),
> + MT8196_TYPE0_PIN(14, "SRCLKENA2"),
> + MT8196_TYPE0_PIN(15, "SRCLKENAI0"),
> + MT8196_TYPE0_PIN(16, "SRCLKENAI1"),
> + MT8196_TYPE0_PIN(17, "MD_INT0"),
> + MT8196_TYPE0_PIN(18, "DMIC1_CLK"),
> + MT8196_TYPE0_PIN(19, "DMIC1_DAT"),
These names are duplicate of 0 and 1. I think it would be confusing to have
duplicate names since the name could not identify the actual pin and
probably makes some pins unuseable by name. There are some other duplicates
as well.
