On 2026-09-25 12:56, Torsten Duwe wrote:
> From: Torsten Duwe <[email protected]>
>
> Add a driver for the clocks in RP1, starting with ETH_TSU.
> Derived from Linux drivers/clk/clk-rp1.c.
>
> Signed-off-by: Torsten Duwe <[email protected]>
> Co-authored-by: Oleksii Moisieiev <[email protected]>
If Oleksii wrote part of this, he needs his own Signed-off-by too.
Please use Co-developed-by plus his Signed-off-by, like in the kernel.
Same for patch 5, 6 and 7.
[...]
> diff --git a/drivers/clk/clk-rp1.c b/drivers/clk/clk-rp1.c
> new file mode 100644
> index 00000000000..94e12271345
> --- /dev/null
> +++ b/drivers/clk/clk-rp1.c
> @@ -0,0 +1,280 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Clock driver for RP1 PCIe multifunction chip.
> + *
> + * Copyright (C) 2024 EPAM Systems
> + *
> + * Derived from linux clk-rp1 driver
> + * Copyright (C) 2023 Raspberry Pi Ltd.
> + */
> +
> +#include <clk.h>
> +#include <clk-uclass.h>
> +#include <dm.h>
> +#include <errno.h>
> +#include <asm/io.h>
> +#include <linux/bitops.h>
> +#include <linux/clk-provider.h>
> +#include <linux/math64.h>
> +
> +#include <dt-bindings/clk/rp1.h>
This header is already in the tree:
dts/upstream/include/dt-bindings/clock/raspberrypi,rp1-clocks.h
The values are the same. Can't that one be used and drop the copy.
[...]
> +
> +U_BOOT_DRIVER(clk_rp1) = {
> + .name = "rp1-clk",
> + .id = UCLASS_CLK,
> + .of_match = rp1_clk_of_match,
> + .probe = rp1_clk_probe,
> + .ops = &rp1_clk_ops,
> + .priv_auto = sizeof(struct rp1_clockman),
> + .flags = CLK_IGNORE_UNUSED,
Is this flag really needed?
Cheers,
Anders
