Hi Heiko, On 2026-09-22T06:09:29, Heiko Schocher <[email protected]> wrote:
> The 23LCV1024 is a 1 Mbit serial SRAM with battery backup on an SPI > bus, used as non volatile scratch storage. This adds a driver for it, > plus a sandbox emulation and a unit test. Just to check the placement: this is an SRAM, not a NOR flash, yet both the driver and its sandbox emulation land in drivers/mtd/spi/ next to the flash code, and the driver is bound to the spi_flash uclass. Have you considered drivers/misc/ or a new drivers/mtd/spi-ram/, with either a dedicated uclass or UCLASS_MTD directly? Piggy-backing on spi_flash to reach the sf command works, but the naming is a bit confusing. > Patch 2 and 3 touch sandbox and the tests not the SPI NOR subsystem. Not quite - patch 2 modifies drivers/mtd/spi/sandbox.c and patch 3 adds drivers/mtd/spi/spi_ram_sandbox.c plus Kconfig/Makefile entries in the same directory, so they very much sit inside the SPI NOR subsystem tree. Please reword this in v2. Patch 2 introduces a new sandbox,emul device-tree property but I don't see a binding document for it. Please add a short binding under doc/device-tree-bindings/ (or extend the existing sandbox SPI binding) describing what it means, with an example. Regards, Simon
