Hi Sumit,

On 2026-09-28T06:40:33, Sumit Singh Dhami <[email protected]> wrote:

> Sumit Singh Dhami (8):
> ...
>   configs: add fastboot config options for writing GPT

I seem to be missing a patch? Perhaps a patchwork problem.

> No option available in 'gpt write' to set full 64-bit gpt partition
> attributes.

This adds a Kconfig option and a new field plus a 'valid' flag to
struct disk_partition, but the struct already holds the top 16 bits of
the attributes in type_flags unconditionally, so we end up with two
partial copies of the same on-disk field. Did you consider widening
the existing field to the full 64 bits, without a Kconfig option? That
would avoid layout differences between builds and keep the read and
write paths symmetric. What do you think?

Regards,
Simon

Reply via email to