On Wed, Sep 30, 2026 at 16:47:33 +0100, Quentin Schulz wrote: > Hi Carlo,
Hi Quentin, > Had a glance at this (am not really interested in Mediatek :) ), and the > single question I would have is: > > why have SPL_ in the middle of the Kconfig symbol? > > Can't you just have > > SPL_MTK_BROM_DOWNLOAD_AGENT_FASTBOOT for SPL > MTK_BROM_DOWNLOAD_AGENT_FASTBOOT for proper > > so you can use CONFIG_IS_ENABLED(MTK_BROM_DOWNLOAD_AGENT_FASTBOOT)? You can > always use IS_ENABLED(CONFIG_SPL_MTK_BROM_DOWNLOAD_AGENT_FASTBOOT) if you > want to check the symbol for a specific stage. Well, not a bad idea at all :) I need to check there are no weird edge cases but in theory it is a nice cleanup. Thanks for the suggestion (I will still wait a bit for more reviews before pushing a new revision). cheers and thanks, -- Carlo Caione
