On Thu, Oct 01, 2026 at 02:30:12AM +0100, Simon Glass wrote: > Hi Tom, > > On Tue, 29 Sept 2026 at 01:49, Tom Rini <[email protected]> wrote: > > > > On Mon, Sep 28, 2026 at 08:39:37AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 15 Sept 2026 at 12:49, Tom Rini <[email protected]> wrote: > > > > > > > > On Tue, Sep 01, 2026 at 03:50:35PM +0530, Naveen Kumar Chaudhary wrote: > > > > > If the malloc() for the UPL handoff structure failed, ret was checked > > > > > while still uninitialized, leading to undefined behavior: either a > > > > > bogus > > > > > error code was returned or, if ret happened to be zero, gd_set_upl() > > > > > was > > > > > called with a NULL pointer. Bail out with -ENOMEM on allocation > > > > > failure > > > > > and only read ret after upl_read_handoff() has set it. > > > > > > > > > > Fixes: 0fc406ab20e ("upl: Plumb in universal payload to the init > > > > > process") > > > > > Signed-off-by: Naveen Kumar Chaudhary <[email protected]> > > > > > > > > I've seen this a few times, I'm curious why you have 11 chars of the > > > > sha1 for the Fixes tag, and not 12? > > > > > > I probably copy it from the short log, which currently uses 11 - > > > sometimes I forget to look it up and add the extra digit... > > > > Why would the short log be 11 and not 12? That's what the kernel (and > > us...) moved to from 8 forever ago. But also, that was a question to > > Naveen... > > For myself, I am not sure of the mechanism, I thought it was > automatic. I only see 11 chars in the short log.
That's so strange. The default value for core.abbrev is 12 (just checked). -- Tom
signature.asc
Description: PGP signature
