Hi Quentin, > > +CONFIG_USE_PREBOOT=y > > +CONFIG_PREBOOT="pci enum; usb start; nvme scan;" > > I know Jonas has been pretty vocal against having PREBOOT set by default > as it drastically increases the boot time in all scenarios. We don't > have many Rockchip boards that set this variable, do you really need it? > Shouldn't bootflow set this up properly when attempting to use > PCI/USB/NVMe storage to locate files?
I patch all of the Fedora builds to enable preboot so yes, I think we really do need it and it should be on all boards. Bootflow doesn't set this up by default, and if it does would it not increase boot time in similar ways? Ultimately these sort of things are always a compromise, for the defaults what would most users prefer, a system that just works with whatever storage they use, or a boot that saves a few seconds. From a Fedora, and likely most other distros are similar, I would prefer a system that works as it means a *LOT* less support tickets/complaints. Users that care about a few extra seconds of boot likely are doing other custom things as part of the process and likely are changing other things in the build config anyway so disabling the storage they don't want to boot from likely isn't a big step. Peter
