Hi Jonas,
On 8/4/26 12:57 PM, Jonas Karlman wrote:
The GRF syscon is referenced using the rockchip,grf prop in SoC DTs.
Change to use syscon_regmap_lookup_by_phandle() to get a GRF regmap
instead of using the inconvenient syscon_get_first_range() method.
This was on my todo-list for so many years, thanks <3
This has no intended behavior change, all affected SoC DTs have the
rockchip,grf reference and the values being written already contain
If they didn't, it would be an issue as the device tree bindings
requires this property to be set.
correct write-enable mask.
Indeed, via HIWORD_MASK() macro which is specific to this device (and
also is badly written as it should be ((val) | (mask) << 16). Can I
tempt you in sending a follow-up patch to change that with
FIELD_PREP_WM16_CONST() instead?
Fixes: bd6375c5511c ("video: rockchip: dw_mipi_dsi: Fix GRF access")
I don't think this patch warrants a Fixes: tag. I will remove this when
applying if I don't forget, except if you disagree.
Reviewed-by: Quentin Schulz <[email protected]>
Thanks!
Quentin
