serial# is flagged write-once (ENV_FLAGS_VARACCESS_PREVENT_OVERWR), so setting it again after it has been loaded from a saved environment gives following unnecessary error logs, which can be avoided.
## Error: Can't overwrite "serial#" ## Error inserting "serial#" variable, errno=1 Return early from qcom_set_serialno() if serial# is already set. Reviewed-by: Casey Connolly <[email protected]> Signed-off-by: Balaji Selvanathan <[email protected]> --- arch/arm/mach-snapdragon/board.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/mach-snapdragon/board.c b/arch/arm/mach-snapdragon/board.c index 87adb100edd..cb8a27dc8a5 100644 --- a/arch/arm/mach-snapdragon/board.c +++ b/arch/arm/mach-snapdragon/board.c @@ -208,6 +208,9 @@ void qcom_set_serialno(void) const char *cmdline; char serial[32]; + if (env_get("serial#")) + return; + if (!qcom_socinfo_init()) return; --- base-commit: 0a55b098d6f5f6bafa84fc2f18b433dd167bf729 change-id: 20261009-serial-set-b7aafbb0da6f Best regards, -- Balaji Selvanathan <[email protected]>
