Hi Simon, Thanks for the review, here and on 1/2. I agree with your points on 1/2: the CONFIG_LOGLEVEL wording is wrong, the select is redundant, and the test overlaps test_vboot.py.
Agreed that one option should control both gates. Rather than posting a v2 of this series, I think the image gate is best folded into Ludwig's series, together with the doc/usage/fit/signature.rst update you asked for. On the dependency: the patches do not apply to bare next at 9e002445cd0d, 1/2 conflicts in boot/Kconfig and tools/mkimage.h with Ludwig's v10. The conflict is textual, not functional. Ludwig, if you take the image gate (fit_image_verify_required_sigs() returning success when the control FDT has no /signature node, reported on Sep 7) into your series, I would appreciate a Reported-by: Eva Crystal <[email protected]> on that patch. Eva Crystal (0xiviel) XSource Security https://xsourcesec.com
