Hi Massimo,

On 2026-10-03T17:00:18, Massimo Pegorer <[email protected]> wrote:
> qconfig: Improve the documentation
>
> Specify where the database is created and under what name. Add text
> value lookup examples, including quoting, escaping and regular
> expression cases. Update other examples, or just their output, in the
> section documenting -f option usage. Trivial fixes.
>
> Signed-off-by: Massimo Pegorer <[email protected]>
>
> doc/develop/qconfig.rst | 40 +++++++++++++++++++++++++++++++---------
>  1 file changed, 31 insertions(+), 9 deletions(-)

> diff --git a/doc/develop/qconfig.rst b/doc/develop/qconfig.rst
> @@ -81,22 +84,41 @@ Each term is CONFIG name, with or without a tilde (~) 
> prefix. The tool searches
> -    tools/qconfig.py -f SCSI ~BLK
> -    3 matches
> -    pg_wcom_seli8_defconfig highbank_defconfig pg_wcom_expu1_defconfig
> +    ./tools/qconfig.py -f PCIE1 ~PCIE2
> +    10 matches
> +    MPC8548CDS_36BIT MPC8548CDS MPC8548CDS_legacy kmcent2

The sentence above still says 'to find boards which enabled
CONFIG_SCSI but not CONFIG_BLK', which no longer matches the example.
Please can you update it to refer to CONFIG_PCIE1 and CONFIG_PCIE2?

> diff --git a/doc/develop/qconfig.rst b/doc/develop/qconfig.rst
> @@ -81,22 +84,41 @@ Each term is CONFIG name, with or without a tilde (~) 
> prefix. The tool searches
> +String values can be searched for, too, including regular expressions, but
> +taking care of needed quoting and escaping. The values stored in the database
> +are the ones from the Kconfig files, before expansion. Moreover, since they 
> are
> +stored with their double quotes, the quotes must be part of the pattern.

This is much clearer, thanks. One point I might have missed earlier:
the pattern must match the whole value, since defconfig_matches() uses
fullmatch(). Otherwise a reader might expect something like '"arch/.*'
to work. Please can you add a sentence about this?

Regards,
Simon

Reply via email to