Hi Ludwig, On 2026-09-23T11:49:31, Ludwig Nussel <[email protected]> wrote:
> - Note: commit 68e65953400 introduced forcing OF_OMIT_DTB which is > incompatible with the intent of the qemu DT merging feature, ie merge > built-in signature nodes into qemu's DT. To be sorted out at some > point. One thing I'd like to check before this series goes in.. with this series applied, qemu_arm64_defconfig still ends up with CONFIG_OF_OMIT_DTB=y, since ARCH_QEMU implies OF_HAS_PRIOR_STAGE and BINMAN is not enabled. OF_OMIT_DTB no longer has a prompt, so the 'is not set' line added to the defconfig in patch 1 has no effect and savedefconfig drops it. As a result qemu_arm64 never has a built-in DT, the merge code in patch 1 always takes the early exit, and the problem in the cover letter (QEMU not seeing the public keys) remains by default. The patch 1 commit message also says the defconfig change enables the feature, which is no longer true. Please can you either fix the Kconfig (e.g. stop defaulting OF_OMIT_DTB to y for QEMU when FIT_SIGNATURE is enabled, or let ARCH_QEMU opt out some other way), or drop the defconfig change and say clearly that the merge only happens on builds that include a DT? A test for the merge itself would be good, perhaps as a follow-up, since none of the vboot tests run on QEMU. This may also be worth checking against the CI failure Tom reported. Regards, Simon
