Hi Jonas,
On 8/4/26 11:44 PM, Jonas Karlman wrote:
The rockchip_get_cru() helper is used by the sysreset_rockchip to get
the SoC specific CRU base address. The helper may trigger a full clock
driver probe to get the fixed CRU base address from the clock driver
private data, something that can take several ms.
OK, but isn't probing the clock driver actually making sure the
assigned-clocks, assigned-clock-parents and assigned-clock-rates
properties are respected? There's *some* side effect. Considering the
current user of that function, they aren't doing anything with clocks so
I guess this is fine on that side. But I'm getting a bit worried, is
there anything actually probing the clock controller driver if we don't
have this anymore? I guess it's fine right now because we only have an
SPL for RK35xx and thus have a Device Tree, but what happens when we
have an open TPL?
Change to return the fixed RK3588 specific CRU base address directly to
simplify and remove the unneeded complexity of using runtime lookup in
SoC specific code.
Signed-off-by: Jonas Karlman <[email protected]>
---
arch/arm/mach-rockchip/rk3588/clk_rk3588.c | 15 +--------------
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/arch/arm/mach-rockchip/rk3588/clk_rk3588.c
b/arch/arm/mach-rockchip/rk3588/clk_rk3588.c
index 250ec423bd24..9b112e45f1de 100644
--- a/arch/arm/mach-rockchip/rk3588/clk_rk3588.c
+++ b/arch/arm/mach-rockchip/rk3588/clk_rk3588.c
@@ -4,10 +4,7 @@
*/
#include <dm.h>
-#include <syscon.h>
-#include <asm/arch-rockchip/clock.h>
#include <asm/arch-rockchip/cru_rk3588.h>
-#include <linux/err.h>
int rockchip_get_clk(struct udevice **devp)
{
There's no user of that function anymore after this patch, so just
squash the patch removing it later in this series with this patch here.
Thanks!
Quentin
