Hi Quentin, On 10/8/2026 11:59 PM, Quentin Schulz wrote: > Hi Jonas, > > On 8/4/26 12:57 PM, Jonas Karlman wrote: >> Modern Rockchip device drivers use syscon_regmap_lookup_by_phandle() >> to get a regmap or use a constant to get the fixed base address. >> >> Remove the unneeded RK3568 syscon driver to discourage new uses of > > Isn't drivers/clk/rockchip/clk_rk3568.c using it? c.f. > syscon_get_first_range(ROCKCHIP_SYSCON_GRF); > Maybe one local test you could do is delete ROCKCHIP_SYSCON_GRF and > ROCKCHIP_SYSCON_PMUGRF temporarily from > arch/arm/include/asm/arch-rockchip/clock.h and rebuild. If it builds, at > least the obvious ones are tackled. > > Same remark for the patch for rk3588 and its clock driver.
These are removed at end of the "rockchip: Miscellaneous RK35xx clock fixes" series [1], v2 is incoming [2]. Looks like I missed to mention this dependency in cover letter. [1] https://lore.kernel.org/all/[email protected]/ [2] https://git.u-boot-project.org/u-boot/contributors/kwiboo/u-boot/-/commits/ci-clk Regards, Jonas > > Otherwise this looks good to me, thanks for the cleanup, much appreciated. > > Cheers, > Quentin
