On Sat, 10 Oct 2026 at 14:15, Petr Hodina via B4 Relay <[email protected]> wrote: > > From: Petr Hodina <[email protected]> > > Enable: > - the ADC volume keys and the keyboard glue with phone key remap > - the USB gadget stack with DFU (SF/MMC/RAM) and mass storage
USB support isn't there yet, upstream DT doesn't even have the bits needed, how did you test that? > - the watchdog > - the clk/pause commands What are they needed for? The change log should explain why, not what, the later can be seen in the change itself. Also it should be broken down into individual bits. EG the USB isn't needed for keys etc. > > Signed-off-by: Petr Hodina <[email protected]> > --- > Enable the pieces needed to drive the Pinephone Pro without a serial > console: > - the ADC and GPIO buttons with the keyboard glue and phone key > remap > - the USB gadget stack with DFU (RAM/MMC/SF) and mass storage, > - the watchdog > - the clk/pause commands. > > The volume keys depend on the separate "button: adc: implement > get_code()" patch to produce key codes. > --- > configs/pinephone-pro-rk3399_defconfig | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/configs/pinephone-pro-rk3399_defconfig > b/configs/pinephone-pro-rk3399_defconfig > index 81bc6d5400d..492b188f904 100644 > --- a/configs/pinephone-pro-rk3399_defconfig > +++ b/configs/pinephone-pro-rk3399_defconfig > @@ -29,21 +29,31 @@ CONFIG_SYS_SPI_U_BOOT_OFFS=0xE0000 > CONFIG_SPL_ATF_NO_PLATFORM_PARAM=y > CONFIG_TPL=y > CONFIG_CMD_BOOTZ=y > +CONFIG_CMD_CLK=y > +CONFIG_CMD_DFU=y > CONFIG_CMD_GPIO=y > CONFIG_CMD_GPT=y > CONFIG_CMD_I2C=y > CONFIG_CMD_MMC=y > CONFIG_CMD_USB=y > +CONFIG_CMD_USB_MASS_STORAGE=y > # CONFIG_CMD_SETEXPR is not set > CONFIG_CMD_TIME=y > +CONFIG_CMD_PAUSE=y > CONFIG_CMD_PMIC=y > CONFIG_CMD_REGULATOR=y > CONFIG_SPL_OF_CONTROL=y > CONFIG_OF_SPL_REMOVE_PROPS="clock-names interrupt-parent assigned-clocks > assigned-clock-rates assigned-clock-parents" > CONFIG_ENV_IS_IN_SPI_FLASH=y > CONFIG_ENV_RELOC_GD_ENV_ADDR=y > +CONFIG_BUTTON_REMAP_PHONE_KEYS=y > +CONFIG_BUTTON_ADC=y > +CONFIG_DFU_MMC=y > +CONFIG_DFU_RAM=y > +CONFIG_DFU_SF=y > CONFIG_ROCKCHIP_GPIO=y > CONFIG_SYS_I2C_ROCKCHIP=y > +CONFIG_BUTTON_KEYBOARD=y > CONFIG_LED=y > CONFIG_LED_GPIO=y > CONFIG_MMC_DW=y > @@ -80,8 +90,10 @@ CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y > CONFIG_USB_HOST_ETHER=y > CONFIG_USB_ETHER_ASIX=y > CONFIG_USB_ETHER_RTL8152=y > +CONFIG_USB_GADGET=y > CONFIG_VIDEO=y > CONFIG_DISPLAY=y > CONFIG_VIDEO_ROCKCHIP=y > CONFIG_DISPLAY_ROCKCHIP_EDP=y > +CONFIG_WDT=y > CONFIG_ERRNO_STR=y > > --- > base-commit: ece349ade2973e220f524ce59e59711cc919263f > change-id: 20261010-b4-pinephone-pro-defconfig-f83a60a75767 > > Best regards, > -- > Petr Hodina <[email protected]> > >
