Hi Jonas,
On 10/11/26 12:55 PM, Jonas Karlman wrote:
Hi Quentin,
On 10/9/2026 11:55 AM, Quentin Schulz wrote:
Hi Jonas,
On 8/4/26 11:44 PM, Jonas Karlman wrote:
The rockchip_get_clk() helper is typically used by SDRAM init code of
older SoC generations or to help get the CRU base address from the clock
driver private data.
RK3588 has no uses for the rockchip_get_clk() helper, let's drop it.
Signed-off-by: Jonas Karlman <[email protected]>
---
arch/arm/mach-rockchip/rk3588/clk_rk3588.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/arch/arm/mach-rockchip/rk3588/clk_rk3588.c
b/arch/arm/mach-rockchip/rk3588/clk_rk3588.c
index 9b112e45f1de..272d28e973b3 100644
--- a/arch/arm/mach-rockchip/rk3588/clk_rk3588.c
+++ b/arch/arm/mach-rockchip/rk3588/clk_rk3588.c
@@ -3,15 +3,9 @@
* (C) Copyright 2020 Rockchip Electronics Co., Ltd.
*/
-#include <dm.h>
+#include <linux/kernel.h>
Why do we need this included now?
It seems to be needed due to use of check_member() in the CRU header.
Will make a note of it in the commit message for v2.
Please instead fix the CRU header so it lists what it needs in its own
include file (separate commit prior to removing the unused function
please), otherwise we'll need all includers of the CRU header also
include this.
Cheers,
Quentin
