> We change the return type of spl_fit_images_get_entry and now don't
> check what it returns. We do add a new and useful debug statement.

Yeah, fair point. The return value wasn't buying anything - there's
nothing the caller can do on failure, since the default it already set
up is the fallback.

The out parameter is the actual fix. fit_image_get_address() bails
before the assignment, so bl32_entry and bl33_entry keep what
spl_invoke_atf() initialised them with. Before, the function returned a
stack value that was never written and clobbered that default.

v2 makes it void. opensbi is unchanged - the return is checked there
because there's no default to fall back on.

Thanks for the review.

Reply via email to