Hi Petr,

Thank you for the patch.

On Sun, Oct 04, 2026 at 22:48, Petr Hodina via B4 Relay 
<[email protected]> wrote:

> From: Petr Hodina <[email protected]>
>
> board_late_init() allocates SZ_128M for kernel_addr_r but never
> exported the size, only the address.
>
> kernel_addr_r_size mirrors the existing kernel_comp_addr_r /
> kernel_comp_size pairing already done for the compressed-kernel
> buffer.
>
> Signed-off-by: Petr Hodina <[email protected]>
> ---
>  arch/arm/mach-snapdragon/board.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-snapdragon/board.c 
> b/arch/arm/mach-snapdragon/board.c
> index 829a0109ac7..70d53a30329 100644
> --- a/arch/arm/mach-snapdragon/board.c
> +++ b/arch/arm/mach-snapdragon/board.c
> @@ -530,6 +530,7 @@ int board_late_init(void)
>       status |= !lmb_alloc(SZ_128M, &addr) ?
>               env_set_hex("loadaddr", addr) : 1;
>       status |= env_set_hex("kernel_addr_r", addr);
> +     status |= env_set_hex("kernel_addr_r_size", SZ_128M);

If we really mirroring what's done for kernel_comp_addr_r, can we please
add a new define as well?
For kernel_comp_addr_r, we have KERNEL_COMP_SIZE.

Can we add KERNEL_ADDR_SIZE for example?
This will ensure that we can't mistakenly introduce a mismatch between
kernel_addr_r and kernel_addr_r_size

>       status |= !lmb_alloc(SZ_128M, &addr) ?
>               env_set_hex("ramdisk_addr_r", addr) : 1;
>       status |= !lmb_alloc(KERNEL_COMP_SIZE, &addr) ?
>
> -- 
> 2.55.0

Reply via email to