On Thu, Sep 24, 2026 at 06:10:04PM +0900, Takahiro Kuwano wrote:

> The spi-nor-core.c contains optional logics like SFDP and manufcaturer
> specific fixups. The spi-nor-ids.c has single large ID database. There
> are many #ifdef directives in those files and that negatively affects
> readability and maintainability.
> 
> This series, as the first step of cleanup, move SFDP logic, IDs, and
> fixups to newly source files. Reworking, renaming, and reformating
> existing code is not a scope of this series and further cleanup will be
> taken place in follow-up patches.
> 
> Here is the code size impact when applying this series.
> Measured by my AMD Zynq-7000 (ARM32) environment with SFDP and all
> manufcaturers are enabled.
> 
> SPI-NOR:
>             text    data     bss     dec     hex filename
> BEFORE    731133   14696       0  745829   b6165 u-boot
> AFTER     732301   14696       0  746997   b65f5 u-boot
> DELTA      +1168       0       0
> 
> TINY:
>             text    data     bss     dec     hex filename
> BEFORE     80492    3744     248   84484   14a04 spl/u-boot-spl
> AFTER      80748    3744     248   84740   14b04 spl/u-boot-spl
> DELTA       +256
> 
> ---
> Changes in v2:
> - Rebase on top of next
> - Link to v1: 
> https://lore.kernel.org/u-boot/20260612-split-id-table-into-vendor-files-v1-0-dfaaa82cc...@infineon.com/

Sorry, sandbox still doesn't compile:
/home/trini/u-boot/u-boot/drivers/mtd/spi/sandbox.c:156:14: error: use of 
undeclared identifier 'spi_nor_ids'; did you mean 'spi_nor_scan'?
  156 |         for (data = spi_nor_ids; data->name; data++) {
      |                     ^~~~~~~~~~~
      |                     spi_nor_scan
/home/trini/u-boot/u-boot/include/linux/mtd/spi-nor.h:656:5: note: 
'spi_nor_scan' declared here
  656 | int spi_nor_scan(struct spi_nor *nor);
      |     ^
1 error generated.

-- 
Tom

Attachment: signature.asc
Description: PGP signature

Reply via email to