On 10/16/2026 2:35 PM, Markus Schneider-Pargmann wrote:
> Add a helper to wait for TIFS initialization to be finished. Effectively
> this is just a call to get_ti_sci_handle() but I think a separate
> function makes the purpose of this call better visible.
> 
> get_ti_sci_handle() internally leads to fetching the TIFS version with a
> message and response. TIFS only responds once initialization finished.
> If a response is not received get_ti_sci_handle() returns after a
> timeout.
> 
> Signed-off-by: Markus Schneider-Pargmann <[email protected]>
> ---
>  arch/arm/mach-k3/common.c | 10 ++++++++++
>  arch/arm/mach-k3/common.h |  1 +
>  2 files changed, 11 insertions(+)
> 
> diff --git a/arch/arm/mach-k3/common.c b/arch/arm/mach-k3/common.c
> index 6e382efdb3be..480c90cfa65f 100644
> --- a/arch/arm/mach-k3/common.c
> +++ b/arch/arm/mach-k3/common.c
> @@ -54,6 +54,16 @@ struct ti_sci_handle *get_ti_sci_handle(void)
>       return (struct ti_sci_handle *)ti_sci_get_handle_from_sysfw(dev);
>  }
>  
> +void k3_sysfw_wait_ready(void)

Please put some warning on use of this function.
On few SOCs like J721E, u-boot loads the TIFS firmware.
In such case, no point of calling this function.

With added comments, please use

Reviewed-by: Udit Kumar <[email protected]>

> +{
> +     /*
> +      * Wait for TIFS initialization to finish. This helper is used to make
> +      * sure TIFS removed the firewall before U-Boot tries to unlock CTRL_MMR
> +      * registers and continues the boot.
> +      */
> +     get_ti_sci_handle();
> +}
> +
>  void k3_sysfw_print_ver(void)
>  {
>       struct ti_sci_handle *ti_sci = get_ti_sci_handle();
> diff --git a/arch/arm/mach-k3/common.h b/arch/arm/mach-k3/common.h
> index 37ff98d89924..146b986febc6 100644
> --- a/arch/arm/mach-k3/common.h
> +++ b/arch/arm/mach-k3/common.h
> @@ -38,6 +38,7 @@ void disable_linefill_optimization(void);
>  int remove_fwl_region(struct fwl_data *fwl);
>  void remove_fwl_configs(struct fwl_data *fwl_data, size_t fwl_data_size);
>  int load_firmware(char *name_fw, char *name_loadaddr, u32 *loadaddr);
> +void k3_sysfw_wait_ready(void);
>  void k3_sysfw_print_ver(void);
>  void k3_dm_print_ver(void);
>  void spl_enable_cache(void);
> 

Reply via email to