On Fri, Oct 16, 2026 at 04:51:34PM -0700, E Shattow wrote:
> Hi João Paulo,
> 
> On 10/16/26 12:52, João Paulo Gonçalves wrote:
> > Add support for the Milk-V Duo S, a development board based on the
> > Sophgo SG2000 SoC with 512 MiB of RAM.
> > 
> > The SG2000 differs from the CV1800B used on the Milk-V Duo 64M and the
> > SG2002 used on the Milk-V Duo 256M, but these SoCs share most of their
> > IP blocks, including the CPU core, so the existing CV1800B support can
> > be reused.
> > 
> > Add a separate board directory, target and defconfig for the Duo S,
> > based on the Milk-V Duo 256M ones. Like the Duo 256M, it reuses the
> > common Milk-V Duo board code. The defconfig uses the upstream devicetree
> > via OF_UPSTREAM.
> > 
> > Link: https://milkv.io/docs/duo/getting-started/duos
> > Signed-off-by: João Paulo Gonçalves <[email protected]>
> > Acked-by: Andrei Lalaev <[email protected]>
> > Acked-by: Hiago De Franco <[email protected]>
> > ---
> >  arch/riscv/Kconfig                       |  4 ++
> >  board/sophgo/milkv_duo_s/Kconfig         | 30 +++++++++++
> >  board/sophgo/milkv_duo_s/MAINTAINERS     |  8 +++
> >  board/sophgo/milkv_duo_s/Makefile        |  6 +++
> >  board/sophgo/milkv_duo_s/milkv_duo_s.env |  8 +++
> >  configs/milkv_duo_s_defconfig            | 43 ++++++++++++++++
> >  doc/board/sophgo/index.rst               |  1 +
> >  doc/board/sophgo/milkv_duo_s.rst         | 86 
> > ++++++++++++++++++++++++++++++++
> >  include/configs/milkv_duo_s.h            | 12 +++++
> >  9 files changed, 198 insertions(+)
> > 

...

> > diff --git a/configs/milkv_duo_s_defconfig b/configs/milkv_duo_s_defconfig
> > new file mode 100644
> > index 000000000000..41a31c4ad46c
> > --- /dev/null
> > +++ b/configs/milkv_duo_s_defconfig
> > @@ -0,0 +1,43 @@
> > +CONFIG_RISCV=y
> > +CONFIG_SYS_MALLOC_LEN=0x820000
> > +CONFIG_SYS_MALLOC_F_LEN=0x8000
> > +CONFIG_NR_DRAM_BANKS=1
> > +CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
> > +CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x82300000
> > +CONFIG_DEFAULT_DEVICE_TREE="sophgo/sg2000-milkv-duo-s"
> > +CONFIG_SYS_LOAD_ADDR=0x80080000
> > +CONFIG_IDENT_STRING=" milkv_duo_s"
> > +CONFIG_TARGET_MILKV_DUO_S=y
> > +CONFIG_ARCH_RV64I=y
> > +CONFIG_RISCV_SMODE=y
> > +CONFIG_FIT=y
> > +CONFIG_BOOTSTD_FULL=y
> > +# CONFIG_BOOTMETH_EFI_BOOTMGR is not set
> > +CONFIG_SD_BOOT=y
> > +CONFIG_SYS_CBSIZE=512
> > +CONFIG_SYS_PBSIZE=544
> > +CONFIG_SYS_PROMPT="milkv_duo_s# "
> 
> Delete CONFIG_SYS_PROMPT there is no purpose for non-default here

This is the same for the other Milk-V Duo boards (CV1800B and SG2002). I
like the idea to have this with the board name and I do not see this as
a blocker for the series. If this needs to be removed, I would remove
the other boards as well, which I prefer not to do.

> 
> > +# CONFIG_CMD_BOOTDEV is not set
> > +CONFIG_CMD_MBR=y
> > +CONFIG_CMD_MMC=y
> > +CONFIG_CMD_POWEROFF=y
> > +# CONFIG_CMD_MII is not set
> > +CONFIG_CMD_EXT4_WRITE=y
> > +# CONFIG_ISO_PARTITION is not set
> > +# CONFIG_EFI_PARTITION is not set
> > +CONFIG_OF_UPSTREAM=y
> > +CONFIG_ENV_OVERWRITE=y
> > +CONFIG_NET_RANDOM_ETHADDR=y
> > +CONFIG_CLK_SOPHGO_CV1800B=y
> > +CONFIG_MMC=y
> > +CONFIG_MMC_IO_VOLTAGE=y
> > +CONFIG_MMC_UHS_SUPPORT=y
> > +CONFIG_MMC_SDHCI=y
> > +CONFIG_MMC_SDHCI_ADMA=y
> > +CONFIG_MMC_SDHCI_CV1800B=y
> > +CONFIG_ETH_DESIGNWARE=y
> > +CONFIG_SYS_NS16550=y
> > +CONFIG_SYS_NS16550_MEM32=y
> > +CONFIG_SPI=y
> > +CONFIG_SYSRESET=y
> > +CONFIG_SYSRESET_CV1800B=y

...

Best regards,
-- 
Hiago

Reply via email to