Hi Mattijs,

On Thu, Oct 15, 2026 at 3:55 PM Mattijs Korpershoek
<[email protected]> wrote:
>
> The setup_android_image() is only called once. The callers does not use
> the return value.
>
> Drop the unused return. While at it, also remove the verbose printing.
>
> Signed-off-by: Mattijs Korpershoek <[email protected]>
> ---
>  test/py/tests/test_android/android_image.py | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/test/py/tests/test_android/android_image.py 
> b/test/py/tests/test_android/android_image.py
> index 3bea311586bf..8b536754656e 100644
> --- a/test/py/tests/test_android/android_image.py
> +++ b/test/py/tests/test_android/android_image.py
> @@ -81,8 +81,6 @@ def setup_android_image(ubman):
>      with open(fname, 'wb') as outf:
>          outf.write(disk_data)
>
> -    print(f'wrote to {fname}')
> -
>      mmc_dev = 8
>      fname = os.path.join(ubman.config.source_dir, f'mmc{mmc_dev}.img')
>      utils.run_and_log(ubman, f'qemu-img create {fname} 20M')
> @@ -129,7 +127,3 @@ def setup_android_image(ubman):
>
>      with open(fname, 'wb') as outf:
>          outf.write(disk_data)
> -
> -    print(f'wrote to {fname}')
> -
> -    return fname
>
> --
> 2.56.0
>

Reviewed-by: Igor Opaniuk <[email protected]>

Reply via email to