Hi Reza, Reza Kurniawan <[email protected]> wrote:
> Is changing 1 << bpix appropriate in this case? Since bpix is already set to > VNBITS(priv->bpix), that bit shift shouldn't be aimed at calculating the bits > out of a log2 bpp. Should this be left out? You are right, sorry, I misread that one. 'bpix' there is already in bits (from VNBITS()), so VNBITS() does not apply. Please leave it out. As an aside, '1 << bpix' in that debug() looks wrong anyway (for a 32bpp display it overflows), but that is a pre-existing bug and not for this series. Regards, Simon
