Hi Jan,
On 2026-10-16T07:26:37, Jan Kehren <[email protected]> wrote:
> On the total_compute motivation: that board carries only CONFIG_LIBAVB
> since 867e16ae05e2 dropped AVB_VERIFY and CMD_AVB, so its
> "avb init ${blk_dev} 0" fails as an unknown command, not a usage error.
Thanks for tracking that down. One thing I'd like to check: patch 3
still calls total_compute 'the user that benefits', but this series
doesn't make that board work. Since 867e16ae05e2 was a savedefconfig
resync, AVB_VERIFY was probably dropped because the board doesn't
enable one of its dependencies. After this series AVB_VERIFY still
depends on MMC and FASTBOOT, and total_compute has no FASTBOOT. So the
board's env script will still run a command that doesn't exist, and
that script is the only in-tree caller of the new two-argument form.
I suggest you add a patch that turns AVB back on for total_compute (if
FASTBOOT is acceptable there, or the dependency can be relaxed), or
reword the patch 3 motivation so it doesn't rely on that board? It
would also be worth copying the total_compute maintainers so they can
say whether that Android flow is still used.
Regards,
Simon
