On Wed, Oct 21, 2026 at 05:15:32PM +0800, Kuan-Wei Chiu wrote:
> Hi Simon,
> 
> On Mon, Oct 19, 2026 at 06:27:33AM -0700, Simon Glass wrote:
> > Hi Kuan-Wei,
> > 
> > On 2026-10-16T04:02:12, Kuan-Wei Chiu <[email protected]> wrote:
> > > arm: Add Google Tensor SoC architecture support
> > >
> > > The first four Google Tensor SoCs were offshoots of Samsung Exynos
> > > SoCs. Starting with the Google Tensor G5 SoC in Pixel 10 phones,
> > > Google Tensor SoCs are of Google's own design. Add ARCH_GOOGLE and
> > > the mach-google directory to support this SoC family.
> > >
> > > Signed-off-by: Kuan-Wei Chiu <[email protected]>
> > >
> > >  MAINTAINERS                  |  6 ++++++
> > >  arch/arm/Kconfig             | 21 +++++++++++++++++++++
> > >  arch/arm/mach-google/Kconfig |  7 +++++++
> > >  3 files changed, 34 insertions(+)
> > 
> > > diff --git a/arch/arm/mach-google/Kconfig b/arch/arm/mach-google/Kconfig
> > > new file mode 100644
> > > index 00000000000..a9e605ebb82
> > > --- /dev/null
> > > +++ b/arch/arm/mach-google/Kconfig
> > > @@ -0,0 +1,7 @@
> > > +
> > > +if ARCH_GOOGLE
> > 
> > The SPDX header is missing, and patch 2/4 adds it to a file this patch
> > created. Please can you add '# SPDX-License-Identifier:
> > GPL-2.0-or-later' as the first line here, and drop the leading blank
> > line, so the file is correct from the start.
> 
> Ack. Will add.
> 
> > 
> > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > > @@ -2252,6 +2252,25 @@ config ARCH_GXP
> > > +config ARCH_GOOGLE
> > > + bool "Google-Designed SoC family"
> > 
> > "Google-designed SoC family" would be more usual. It is also worth
> > considering "Google Tensor SoC family" since that is the name used
> > everywhere else in the series and in the help text.
> 
> This prompt and the help text below were taken from the Kconfig in the
> upstream Linux kernel to keep them consistent. It uses Google-designed
> rather than Google Tensor because Tensor G1 to G4 are also branded as
> Google Tensor SoCs, but they are supported under ARCH_EXYNOS.
> 
> > 
> > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > > @@ -2252,6 +2252,25 @@ config ARCH_GXP
> > > + select OF_UPSTREAM
> > > + select POSITION_INDEPENDENT
> > 
> > Just to check, is POSITION_INDEPENDENT actually required, or just a
> > convenience given the BL33 load address ? Forcing it on means
> > downstream boards cannot opt out. If it is only needed for the current
> > defconfig, 'imply' would be a better fit than 'select'.
> 
> I'll change it to imply in v2.

Don't change it unless there's some reason you'd ever want to be
hard-coding the address.

-- 
Tom

Attachment: signature.asc
Description: PGP signature

Reply via email to