Hi all, On Fri, Oct 23, 2026 at 1:32 PM Guillaume La Roque <[email protected]> wrote: > > On Thu, 22 Oct 2026 14:17:00 +0200, Igor Opaniuk > <[email protected]> wrote: > > Hi Igor, > > Thanks for your multiple fix in fastboot. > > > > > diff --git a/net/fastboot_tcp.c b/net/fastboot_tcp.c > > index 3ea25c997fcc..ed32e5311b45 100644 > > --- a/net/fastboot_tcp.c > > +++ b/net/fastboot_tcp.c > > @@ -16,17 +17,95 @@ static const uchar *handshake = "FB01"; > > [ ... skip 37 lines ... ] > > + */ > > +static int dl_consume(const char *buf, int len) > > +{ > > + int left = len; > > + > > + while (left && fastboot_data_remaining()) { > > varaible use in fastboot_data_remaining was properly reset after a succefull > download(fastboot_data_complete) but if download stop in middle or error > i don't see any reset, do you test this scenario ? > initiate download , stop it from host or unplug cable , relaunch a > download, if i understand properly while loop still use in > fastboot_data_remaining value from previous download.
We've had a pm discussion with Guillaume, and pointed to Carlos' patch series: https://lore.kernel.org/all/20261014-ccaione-upstream-spl-fastboot-boot-v1-2-d29df15fb...@baylibre.com/ It looks like he's addressing a similar issue with reset, but in the common fastboot code. I'll wait for his patches to land, then rebase my changes on top, re-use his reset implementation in tcp fb code and send out v2. > > -- > Guillaume La Roque <[email protected]>
