On Tue, Oct 27, 2026 at 12:17 PM Quentin Schulz <[email protected]> wrote:
>
> Hi Dennis,
>
> On 10/12/26 4:01 AM, Dennis Gilmore wrote:
> > The Xunlong Orange Pi 5 Pro is a single-board computer based on the
> > Rockchip RK3588S SoC. The board provides many interfaces, including
> > two HDMI output ports, a PCIe-attached Motorcomm YT6801 1GbE port,
> > an M.2 M-Key slot, one USB 3.0 and four USB 2.0 ports.
> >
> > Features tested on an Orange Pi 5 Pro 16GB:
> > - SD-card boot
> > - eMMC boot
> > - PCIe/NVMe
> >
> > The devicetree is taken from Linux v7.3 via the preceding dts/upstream
> > picks.
> >
> > The upstream devicetree muxes the PERST# pin of pcie2x1l1 and
> > pcie2x1l2 to the controller's dedicated function while also using it
> > as reset-gpios. Linux switches the pin to GPIO when it is requested,
> > U-Boot does not, and probing pcie2x1l2 then hangs. Override the
> > pinctrl in the -u-boot.dtsi to use GPIO function for the reset pins,
> > like rk3568-rock-3a-u-boot.dtsi does, until the Linux devicetree is
> > fixed.
> >
> > Link: 
> > https://lore.kernel.org/linux-rockchip/[email protected]/
> > Signed-off-by: Dennis Gilmore <[email protected]>
> > Reviewed-by: Jonas Karlman <[email protected]>
> > ---
> >
> > Changes in v2:
> > - Add Link to the Linux devicetree PERST# fix (Quentin)
> > - Move MAINTAINERS entry into alphabetical order (Quentin)
> > - Add Jonas as reviewer in MAINTAINERS (Jonas)
> > - Drop USE_PREBOOT/PREBOOT (Quentin, Jonas)
> > - Drop DISPLAY_BOARDINFO_LATE, Model and SoC were printed twice (Jonas)
> > - Drop OF_SPL_REMOVE_PROPS, use the default (Quentin)
>
> I meant to only drop clock-names from OF_SPL_REMOVE_PROPS, not the whole
> OF_SPL_REMOVE_PROPS.
>
> Do you mind if I apply this patch with
>
> CONFIG_OF_SPL_REMOVE_PROPS="interrupt-parent assigned-clocks
> assigned-clock-rates assigned-clock-parents"
>
> added to the defconfig (I'll mention the change made in the commit log)?
> This would be consistent with the other more recent Rockchip defconfigs.
>
> Note that the first 4 commits are now unnecessary as Tom has merged v7.3
> Device Tree into the main branch.
>
> Cheers,
> Quentin

Hi Quentin,

I am not at all opposed to that

Dennis

Reply via email to