Hi Jonas, On 2026-10-11T22:28:36, Jonas Karlman <[email protected]> wrote:
> Some of these fixes have only been compile tested as it involves clocks > or rates that are rarely used in U-Boot. Please can you say which patches were tested on hardware, and on which boards? Patches 1 to 6 and 14 change PLL and bus-clock setup that every RK3568/RK3576/RK3588 board runs at boot, so they carry more risk than the one-line copy-paste fixes. Knowing which ones still need a run on real hardware would help the people testing on the various SoCs. > This series fixes a few trivial copy-paste mistakes and other misc clock > issues for RK35xx SoCs. Within each SoC the fixes are mixed with cosmetic changes (the macro renames and removals, the PLL-table alignment, SPLL_HZ and the GRF lookup drops). Several of the cosmetic ones carry a Fixes: tag even though they don't change behaviour, e.g. the PPLL macro renames, the unused-macro removals and the PWM0 shift change, whose commit message says as much. It would be worth moving the real fixes to the front of the series and keeping Fixes: only on patches that change behaviour. Then the fixes can be picked up (and backported) on their own, while the tidy-ups wait for the next merge window. What do you think? Regards, Simon
