Hi Nikita,

On 2026-09-02T06:31:15, Nikita Shubin <[email protected]> wrote:
> test: spl: Zero spl_image_info
>
> Make sure spl_image_info is inited before passing it.

Please can you give the reason in the commit message? The next patch
makes spl_load_fit_image() check spl_image->fdt_addr, so if these
tests leave the struct uninitialised it may write loadables to a
random stack address. The normal SPL path in board_init_r() already
does a memset(), so the tests should do the same. Also, please use
'initialised' rather than 'inited'.

>
> Signed-off-by: Nikita Shubin <[email protected]>
>
>  test/image/spl_load_os.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Regards,
Simon

Reply via email to