Here's an example of how I rewrote some code.

Old version
284: *         IF F200.SCHEME.CODE = "CK1" OR F200.SCHEME.CODE = "CK2"
OR F200.SCHEME.CODE = "NU1" OR F200.SCHEME.CODE = "NU2" OR
F200.SCHEME.CODE = "TK1" OR F200.SCHEME.CODE = "TK2" OR F200.SCHEME.CODE
= "GS1" OR F200.SCHEME.CODE = "JM" OR F200.SCHEME.CODE = "MP3" OR
F200.SCHEME.CODE = "LHC" OR F200.CALC.CODE = "H" OR F500.S91.ANNUITY.SEQ
+ 0 >= 2 OR F500.S48.ANNUITY.SEQ + 0 >= 2 OR F200.SCHEME.CODE = "AF1" OR
F200.SCHEME.CODE = "MP" THEN    ; *002
285:          IF F200.SCHEME.CODE = "CK1" OR F200.SCHEME.CODE = "CK2" OR
F200.SCHEME.CODE = "NU1" OR F200.SCHEME.CODE = "NU2" OR F200.SCHEME.CODE
= "TK1" OR F200.SCHEME.CODE = "TK2" OR F200.SCHEME.CODE = "LHC" OR
F200.CALC.CODE = "H" OR F500.S91.ANNUITY.SEQ + 0 >= 2 OR
F500.S48.ANNUITY.SEQ + 0 >= 2 OR F200.SCHEME.CODE = "MP" OR
F200.SCHEME.CODE = "AF1" THEN     ; *002*003

New version
261:          THAT = @TRUE
262: *        TEST = '\AF1\CK1\CK2\GS1\H\JM\LHC\MP\MP3\NU1\NU2\TK1\TK2\'
263:          TEST = '\AF1\CK1\CK2\H\LHC\MP\NU1\NU2\TK1\TK2\'
264:          IF INDEX(TEST,'\':F200.SCHEME.CODE:'\',1) THEN THAT =
@FALSE
265:
266:          IF F500.S91.ANNUITY.SEQ + 0 GE 2 THEN THAT = @FALSE
267:          IF F500.S48.ANNUITY.SEQ + 0 GE 2 THEN THAT = @FALSE

I think the new version is easier to maintain (well I would say that),
but the code itself is more complex; which is rather interesting.


Regards, Keith
-------
u2-users mailing list
[email protected]
To unsubscribe please visit http://listserver.u2ug.org/

Reply via email to