I see contributor as anyone who contributed to me figuring it all out,
plus I'd ideally like to use your executeCommand function, so with
luck you will be a contributor!

The problem with the existing email command is that it assumes a few
things in the function which make it less than optimal for aliasing:

  execute: function(directObj, headers) {
    var html = directObj.html;
    var document = context.focusedWindow.document;
    var title;
    var toAddress = "";

    if (document.title)        <--------------------------- HERE
      title = document.title;
    else
      title = html;

    var location = document.location;   <------- Extraneous
    var gmailTab = findGmailTab();
    var pageLink = "<a href=\"" + location + "\">" + title + "</a>";

    if (html) {  <--------------------------- AND HERE
      html = ("<p>From the page " + pageLink + ":</p>" + html);
    } else {
      // If there's no selection, just send the current page.
      html = "<p>You might be interested in " + pageLink + ".</p>";
    }

    title = "'" + title + "'";  <---- Here too
....

- It assumes that if there is no document.title for the page the tab
I'm on that I want the message body to be my email line (as well as
assuming that I want the subject line within single-quotes)
- it also assumes that I want a message with a page-link in my email
body (which ended up undefined in my app)

If just these few lines were changed it would be much easier to alias
this command

On Feb 26, 5:11 pm, lrbabe <[email protected]> wrote:
> This command looks interesting, I've never heard about drop.io but
> with your command this is certainly a useful service.
>
> Can you explain me what was your problem with the existing email
> command, what where the variables that you haven't been able to
> manipulate?
>
> PS: I'm not sure that I deserve to be listed as a contributor to your
> command, I just provided some help through the group, you wrote the
> code alone : )
>
> On Feb 27, 12:29 am, GooseusTheGreen <[email protected]> wrote:
>
> > Oh, I didn't actually get to much in to what the command actually
> > does, did I?
>
> > Usage: drop-file-to-email (drop name) to (contact)
>
> > Description:
> >   Creates a new drop athttp://drop.ioandthen uploads a file which
> > is selected from a file form input in the preview block.  The file is
> > uploaded via multipart/form-data ajax post.  The drop url is then sent
> > to a new GMail composition to the specified contact.
>
> > Makes use of the Drop.io RESTful Dropper API 
> > -http://groups.google.com/group/dropio-api/web/full-api-documentation
>
> > Example: drop-file-to-email myfiledrop to [email protected]
> >   Select a file from the form element in the preview block, hit enter
> > and you get a new gmail composition:
>
> > To: [email protected]
> > Subject: New Drop - [fileName]
> > Body:
> > Download It Here:<br />
> > <a href="http://drop.io/myfiledrop";>[fileName] ([fileSize] bytes)</a>
>
> > On Feb 26, 4:18 pm, GooseusTheGreen <[email protected]> wrote:
>
> > > I heard of Ubiquity awhile ago, but hadn't gotten a chance to mess
> > > with it until recently... since then I've been in love with the idea
> > > of developing these sort of tools.  The first one that came to my mind
> > > was for some friends of mine who send out (via email) medium sized
> > > files using various file transfer sites, including drop.io.  After a
> > > couple of days I now have a drop-file-to-email command
>
> > >http://gist.github.com/71201
>
> > > You can't just subscribe and use the command since you will need to
> > > setup a developer account (for free) at drop.io in order to get the
> > > necessary API key... after you get an API key you can then create
> > > drops and upload files to drop on the fly with some restrictions (30
> > > requests within 15 minutes, but I believe these are file requests, not
> > > server requests).  If anyone is interested in checking it out without
> > > having to sign up you can email me and I'll send you my API key.
>
> > > A couple interesting things I ran in to while making this command:  1)
> > > a problem integrating with the email command using aliases and 2) the
> > > problem of uploading a file using the XMLHttpRequest object.
>
> > > Thanks to this article (http://igstan.blogspot.com/2009/01/pure-
> > > javascript-file-upload.html),  I got code to create a coupleof
> > > functions which will perform a multipart/form-data post (including
> > > binary data from a file input element) using the XMLHttpRequest object
> > > and which only works in FF3 (thanks to it's extra DOM support for the
> > > aforementioned file input element), making it perfect for use by
> > > Ubiquity.  I mapped the modified functions to CmdUtils as an example
> > > of how a future function MIGHT work (though these definitely need some
> > > work in terms of robustness).
>
> > > Thanks to Irbabe I was put on the path to aliasing the standard-feed
> > > email, but unfortunately the command is a little too specific and I
> > > could not manipulate all the necessary variables.  So instead I copied
> > > out the email execute() function and getGmailTab() functions in to my
> > > own command and made the email function more generic.  I'm wondering
> > > if the the existing email command couldn't just use an alias to a
> > > generic mailer command which is designed simply for aliasing... though
> > > I what point is it easier to make it in to a global function?
>
> > > So yeah, that's what I've been cooking up, let me know any questions,
> > > comments, improvements, etc.
>
> > > - Goose
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"ubiquity-firefox" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/ubiquity-firefox?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to