What Fern said. Basically, the options object that was passed in was modified, rather than a copy of it. As another upside, the fix means less code is run now, since the postData object isn't iterated over twice.
- Blair On 11/5/09 11:11 AM, Fernando Takai wrote: > https://ubiquity.mozilla.com/hg/ubiquity-firefox/rev/13371d06147a > > On Sun, May 10, 2009 at 8:08 PM, Christian Sonne <[email protected] > <mailto:[email protected]>> wrote: > > Blair, was this my fault? :-S and which changeset fixes this? > > > On Mon, May 11, 2009 at 1:04 AM, orangewedge <[email protected] > <mailto:[email protected]>> wrote: > > > Awesome! Thanks for looking into this! > > -Jim > > On May 8, 7:18 pm, Blair McBride <[email protected] > <mailto:[email protected]>> wrote: > > Congratulations! You found a bug! > > > > Anyway, I just found the issue and fixed it - the fix will be > in the > > next release. > > > > - Blair > > > > On 4/5/09 3:03 PM, orangewedge wrote: > > > > > > > > > Not sure what is happening here, but for some reason every > time I use > > > the custom ubiquity command that I have authored below, it > caches the > > > first query. > > > > > For example when I send a POST data query to the intranet > site using > > > the code below with the string "cow", every proceeding use > of the > > > command will use the query string "cow"... The only way I > can free up > > > the "cache" is by restarting the browser or by going to the > actual web > > > page and entering a query into the form. Is this a bug > with Ubiquity? > > > > > Here is the form that I am trying to pass the POST query > data to: > > > <form accept-charset='UNKNOWN' method='POST' action='? > > > Action=ViewPackageRecipeAction' > enctype='application/x-www-form- > > > urlencoded'> > > > Search for Recipe<BR> > > > Enter Package Number:<BR> > > > <input name='RecipeSearchValue' type='TEXT'> > > > <br> > > > <input type='SUBMIT' value='View Recipe'> > > > </form> > > > > > Here is the code for the command "package" where<url> is a > url on my > > > local intranet): > > > CmdUtils.makeSearchCommand({ > > > name: "package", > > > description: "Searches 'package recipe' for your words.", > > > url: "http://<url>?Action=ViewPackageRecipeAction", > > > postData: {"Action": "ViewPackageRecipeAction" , > > > "RecipeSearchValue": "{QUERY}" } > > > }); > > > > > > > > -- > Fernando "Takai" > http://flickr.com/photos/supeertakai > http://twitter.com/fernando_takai > > Get Ubiquity: https://ubiquity.mozilla.com > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "ubiquity-firefox" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/ubiquity-firefox?hl=en -~----------~----~----~----~------~----~------~--~---
