Can you open a ticket on trac and attach the diff? On Aug 26, 2009, at 4:07 PM, pvncad wrote:
> > I have implemented this feature. Patch is available @ > http://github.com/pvncad/misc/blob/ece2b2b4a716c58e20ea77fa7e9f22de02e4e26f/translate.diff > > . > > Could someone review this and commit to the trunk ? > > Way to test: > > Set extensions.ubiquity.default_translation_lang = fr and > extensions.ubiquity.alt_translation_lang = en > So that you will have French as your default language and English as > alternative language. > > If you try to translate non-French text, it will be by default > translated to French and if you try to translate to French text, it > will by default translates to English. > > Regards, > pvncad > > On Aug 20, 8:20 pm, pvncad <[email protected]> wrote: >> Currently, we have only default language setting >> (extensions.ubiquity.default_translation_lang) which will be used as >> target language. >> Only case this setting will fail is when source language is in the >> default language itself. So, I feel adding another property >> (alternative lang) and using it as target language if user is trying >> to translate default language itself. >> >> This means that before translating text, we need to first detect what >> is the source language. >> (Note we can do this step only if user has specified both default and >> alternative langauge). >> >> -pvncad >> >> On Aug 19, 11:35 am, feng <[email protected]> wrote: >> >>> hi all: >>> when i select chinese text in one page, i right click and choose >>> translate , it replaced by english, but when i select english text, >>> and right click choose translate, it also replaced by english, i >>> want >>> it replaced by chinese, >> >>> how to set it ? thanks >> >> > > -- Fernando Takai http://twitter.com/fernando_takai --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "ubiquity-firefox" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/ubiquity-firefox?hl=en -~----------~----~----~----~------~----~------~--~---
