On Thu, Sep 18, 2008 at 11:37 AM, Martin Pitt <[EMAIL PROTECTED]> wrote: > Some review comments: > - postinst: use lt-nl instead of lt for --compare-versions
Cool, thanks. Will change. > - prerm: You should be able to drop this entirely; conffiles are automatically removed on purge Well, I thought it would be a good idea to remove the cronjob even on just a normal removal (in addition to a purge). Once the binary update-motd is gone, the cronjob is broken and is wasting cpu cycles and spewing error messages. Are you sure you want me to remove the prerm? > - there should be a preinst which makes sure you don't get a dpkg conffile conflict question on intra-intrepid upgrades, but don't worry too much about it; developers should be able to figure that out. I talked to Colin about this, and he said not to worry about it...only affecting users running an Alpha version of Intrepid. I noticed it in my testing, and suggested fixing this. > - any reason why you use both dh_install and "install" in debian/rules to install files? ideally they would all use dh_install No good reason. Sorry. > Promoted to main. Thanks!!! :-Dustin -- main inclusion request: update-motd https://bugs.launchpad.net/bugs/260443 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
