On Friday 19 September 2008 17:49:58 Martin Pitt wrote:
> Hi Alberto,
>
> Alberto Milone [2008-09-19 14:35 -0000]:
> > Martin, can you have a look at revision 378 of my branch?
> > ~albertomilone/jockey/jockey-generic-kde
>
> Thanks for working on this. Some questions:
>
> * jockeyKde/ is entirely autogenerated, right? It shouldn't be in
> revision control. Also, can these be generated in a subdirectory of
> kde/, to not clutter the main source directory?
>
Yes, the contents of jockeyKde (i.e. 2 .py files) are generated automatically
at build time. They are real modules which are imported by jockey-kde.
Moving jockeyKde into kde/ (in the source code) wouldn't be a problem.
> * You should merge from trunk again, apparently you are missing some
> changes (I suppose that's also the reason for your test suite
> failures)
>
I did it today but maybe I should start from scratch with a new branch.
> * generateui is a two-line script which is not called by anything
> else. Can it just go?
generateui can be useful when a developer changes the ui files with QtDesigner
and then wants to see the result in the .py file without having to build the
package.
If you want, I can get rid of it and reuse convertpykde.py by simply adding an
if __name__ == "__main__": convertUi()
>
> * {convert,make}pykde.py do not look jockey specific. Shouldn't they
> be part of python-kde4-dev?
>
If you prefer, I can get rid of them by calling /usr/bin/pykdeuic4 with
subprocess in setup.py, it wouldn't be as elegant though (I couldn't check
exceptions in case of malformed .ui files, etc.).
> * If we should really keep kdeTools/ in jockey itself, can it be moved
> into kde/ ?
Yes, sure
Let me know what you think.
Alberto
--
KDE interface fails to start: No module named kurllabel
https://bugs.launchpad.net/bugs/271935
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
