Hi kop, Thanks for your work, it looks good. I have an upload on my disk ready to sponsor now. However, I am going to delay again sorry.
Looking at http://trac.umitproject.org/changeset/3742 and comparing it to your patch, there is a slight difference. Upstream has + ucontent.insert(uline, "sys.path.insert(0,('%s')\n " % modules ) you have + ucontent.insert(uline, "sys.path.insert(0, '/usr/share/umit')\n") taking the bit I am worried about it is insert(0,('%s') vs. insert(0, '/usr/share/umit') or rather, ignoring the different way of specifying the path: insert(0,('%s') and insert(0, '%s') so the upstream one has an extra open bracket. I think yours is correct, and that upstream's will lead to a syntax error. However, I'm not 100% sure, and I don't want to upload something broken, so I'd like you to point this out to upstream and see if you are correct. If they fix their version then I will upload, if not then I will tweak your patch. Thanks, James -- umit higwidgets conflits https://bugs.launchpad.net/bugs/264750 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
