On Fri, 2008-10-03 at 17:41 +0000, James Westby wrote: > Hi Charlie, > > Thanks for working on this. I have a few questions about your patch. > > - #Stop and purge debconf. > - db_stop || true > - db_purge || true > - > > why don't we want to do that any more? For reasons that elude me (need to do further research as to why), this bit of code causes ampache.postrm to hang and not complete when it is present. When removed ampache.postrm completes and purges ampache properly. > > + if [ -d /usr/share/ampache ]; then > + rm -rf /usr/share/ampache > + rm -f /etc/apache2/conf.d/ampache > + fi > > is /etc/apache2/conf.d/ampache a conffile? Yes it is the conf file to create a apache2 alias, it is not ampache's main configuration file. However there is symlink from /etc/ampache/ampache.conf to /etc/apache2/conf.d/ampache. When testing the package I noticed that after purging, /etc/apache2/conf.d/ampache remained, which I believe is a violation of debian policy, so I added the code to remove it. > > + mkdir /usr/share/ampache/www/modules/prototype > + if [ ! -h /usr/share/ampache/www/modules/prototype ]; then > + ln -s /usr/share/javascript/prototype/prototype.js > /usr/share/ampache/www/modules/prototype/ > + fi > > why doesn't this work if the link is in the package? I think you tried to > explain > this along with the patch, but I didn't get it I'm afraid. > Ok let's see if I can explain this a little better. Originally prototyp.js was actually part of the .orig.tar.gz, but with the new version of lintian it complained of prototype.js being part of the .orig.tar.gz as being a "Convenience copy of code" which is a violation of section 4.13 of the debian policy. So to correct this I added -Xprototype.js to dh_install to remove prototype.js from the .deb. I then made the package depend on libjs-prototype.js and used debian/links to create the symlink. Prototype.js resides in /usr/share/ampache/www/modules/prototype/prototype.js, the problem is that dh_install -Xprototype.js would remove the prototype *directory* along with the file prototype.js thus the symlink being created improperly, thus not allowing the package to perform correctly. With Intrepid release rapidly approaching I decided it was easier, and quicker to move all this to ampache.postinst. And yes before you ask I did test 0ubuntu2 in a chroot, which in itself is a part of the problem. I quickly found out that I am not proficient in setting up a proper chroot for testing, after several frustrating attempts and came up with the same results that the package installed and performed correctly, which I new was wrong. So to correct this I went out and bought a used computer and set it up with an Intrepid system and use it exclusively for testing purposes. I hope this explains things better > + cd $BIN > + php ./migrate_config.inc > > can that not be called with the full pathname, instead of using "cd"? > done, used full pathname > Thanks, > > James >
** Attachment added: "amp3-debdiff" http://launchpadlibrarian.net/18203140/amp3-debdiff -- [intrepid] menu buttons don't work on main page https://bugs.launchpad.net/bugs/276945 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
