Also, the patch ensures that logrotate keeps stopping completely if
"missingok" is *not* specified, to not change behaviour in that case.

** Description changed:

  Binary package hint: logrotate
  
  When a package is removed, but not purged, "missingok" usually prevents
  logrotate from complaining about missing files. That has regressed a
  while ago, see Debian bug for details.
  
  --
  
  SRU justification: Any logrotate.d/* file with a nonexisting log
  directory breaks complete log rotation.
  
  Test case:
  
  Create a logrotate snippet with nonexisting file:
  
      echo -e '/var/log/nonexisting/*.log {\n daily\n missingok\n}' | sudo
  tee /etc/logrotate.d/foo
  
  Now check log rotation with
  
      logrotate -d -f /etc/logrotate.conf
  
  With the broken package, it stops at foo, without processing any further
  files:
  
    [...]
    reading config file foo
    error: error accessing /var/log/nonexisting: No such file or directory
    error: foo:1 glob failed for /var/log/nonexisting/*.log
    # exit code 1
  
  With the fixed package, it still logs the glob error, but goes on:
  
    [...]
    reading config file foo
    error: error accessing /var/log/nonexisting: No such file or directory
    error: foo:1 glob failed for /var/log/nonexisting/*.log
    reading config info for /var/log/nonexisting/*.log 
    reading config file ppp
    [...]
+ 
+ However, if "missingok" is not specified, logrotate should continue to
+ stop completely:
+ 
+     echo -e '/var/log/nonexisting/*.log {\n daily\n }' | sudo tee
+ /etc/logrotate.d/foo
+ 
+ 
+   $ logrotate -d -f /etc/logrotate.conf
+   [...]
+   error: error accessing /var/log/nonexisting: No such file or directory
+   error: foo:1 glob failed for /var/log/nonexisting/*.log
+   reading config info for /var/log/nonexisting/*.log 
+   error: foo:3 glob failure without missingok
+   # exit code 1

-- 
missingok does not work
https://bugs.launchpad.net/bugs/256891
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to