On Mon, 2008-10-27 at 21:40 +0000, rydberg wrote: > It *is* possible to make the patch smaller, by 18 lines, by leaving the > if statements untouched, like this: <snip> > However, the resulting code looks rather artifical. Would you prefer a > patch base on the above?
Yes, I think that's better. Not because the code is better, but because the patch is smaller and it's more obvious what you're changing. I find that in general, when submitting patches upstream, it is better to be small and try your best to show exactly what you're changing. Those patches tend to get accepted faster. (and sometimes at all) -- GPM unresponsive for two minutes after startup on Macbooks https://bugs.launchpad.net/bugs/289520 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
