Sergey, Pablo, this is great! Thanks for your efforts. Some comments about the changes: i) the new gnome-archive-install script would preferably be declared as a _SCRIPT rather than _DATA, and needs not be invoked with python (as it has a shebang); see also http://bugzilla.gnome.org/show_bug.cgi?id=565879 which is about fixing the way isoinfo.sh is run and declared in Makefile.am
ii) the three new errors returning FR_PROC_ERROR_GENERIC, FR_PROC_ERROR_FORMAT_NOT_SUPPORTED, and FR_PROC_ERROR_GENERIC respectively all have the same description; would be best to use a different message for each error case so that we can easily identify the error when we receive bug reports with this message iii) I'd like to find a way to upstream this; I expect GNOME upstream would rather have a PackageKit implementation (and for now I think Ubuntu would be best with this gnome-app-install based implementation), so perhaps it makes sense to have this plugin conditionally built, or use a wrapper which dispatches between a (to be written) PK implementation and our GAI one? Please share your thoughts! iv) The patch requires some packaging changes (python policy compliance, new deps etc.), but I can take care of that -- totem-like/firefox-like plugin installer for file-roller https://bugs.launchpad.net/bugs/148084 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
