On Sat, Jan 17, 2009 at 5:17 AM, Loïc Minier <[email protected]> wrote: > By default, dh_* commands act on all packages of debian/control; > currently you only have Arch: all packages, so all packages equals all > arch indep packages. IOW you're calling a command acting on arch indep > and arch specific packages in an arch indep target (binary-indep). But > it's just a nice to have to fix this because you would certainly notice > if you were to add some arch specific packages (hopefully ;-).
Okay, fix committed. > There's a regression in your new upload: > W: screen-profiles source: package-lacks-versioned-build-depends-on-debhelper > 6 > (you're using compat 6). Fix committed. > One thing which would be nice to do is to use the Description to explain why > update-notifier-common and bc are useful dependencies to install (since these > are optional). > > Albeit probably useless by most metrics, you could add an "Enhances: > screen". Fix committed. > You don't need to pass debian/screen-profiles debian/files debian > /screen-profiles.debhelper.log to dh_clean, it cleans these by default. Fix committed. > You should use dpkg-parsechangelog to parse debian/changelog instead of seds. > DEBVERSION := $(shell dpkg-parsechangelog | sed -n -e 's/^Version: //p') > VERSION := $(shell echo $(DEBVERSION) | sed -e 's/-[^-]*$$//') > careful: doesn't strip epochs. Hmm, looks like I could get it to take care of part of the sed, but in the end, I still end up with sed's in line. I'll keep looking at this. But it looks to be relatively low priority. :-Dustin -- main inclusion: screen-profiles https://bugs.launchpad.net/bugs/317214 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
