Hi Daniele,

A few points:

- please submit patches using unidiff format (diff -u) instead of classic diff; 
classic diffs don't include any context to ensure that the patch will apply 
correctly if the target file has changed.
- why have you provided copies of log_action_begin_msg() and 
log_action_end_msg() that are never used?  Even if these are meant to be 
log_daemon_msg() and log_end_msg(), the correct approach is to make irda-utils 
depend on the package that provides /lib/lsb/init-functions, not to work around 
its absence.
- why should irda-utils call sysctl at all from an init script, instead of 
installing a file under /etc/sysctl.d?  Since the file in /etc/sysctl.d would 
be a conffile, users could edit that instead of /etc/default/irda-utils to get 
the same result.

Unsubscribing ubuntu-main-sponsors for the moment.

-- 
IrDA baud_rate not configurable at boot
https://bugs.launchpad.net/bugs/292779
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to